[PLATFORM-1195]: rfc8414 compliance #185
Conversation
MaeIsBad
force-pushed
the
PLATFORM-1195/task/rfc8414-compliance
branch
5 times, most recently
from
acc5086
to
f08e24d
Compare
| url = metadata_url(base_url) | ||
| %HTTPoison.Response{status_code: status_code, body: meta_body} = Telepoison.get!(url, accept: "application/json") | ||
|
|
||
| true = status_code in 200..299 |
There was a problem hiding this comment.
I would handle it in a more graceful way since the error code might be a bit confusing from the user perspective. I think we might custom panic this and the Telepoison.get! to give a more relevant information to the user
There was a problem hiding this comment.
Moreover i think it might be better to call this def fetch!(... being that this function might panic. Otherwise you can return {:ok, __MODULE__.t()} | {:error, atom() | String.t()} and gracefully handle panics
There was a problem hiding this comment.
I've changed it to fetch! and added an exception. I think panicking in this situation makes sense
good point, I assumed it would get cached in redis, I'm not sure if the extra request is worth it |
I didn't think about it but it totally is if you don't configure redis. Maybe if redis isn't configured we could use an ets cache by default? |
|
Either ETS or an |
MaeIsBad
force-pushed
the
PLATFORM-1195/task/rfc8414-compliance
branch
from
c81a948
to
34f3c2f
Compare
MaeIsBad
force-pushed
the
PLATFORM-1195/task/rfc8414-compliance
branch
from
9bbcf25
to
929c4e4
Compare
MaeIsBad
force-pushed
the
PLATFORM-1195/task/rfc8414-compliance
branch
14 times, most recently
from
34584ad
to
dce464c
Compare
MaeIsBad
force-pushed
the
PLATFORM-1195/task/rfc8414-compliance
branch
from
dce464c
to
201079f
Compare
https://prima-assicurazioni-spa.myjetbrains.com/youtrack/issue/PLATFORM-1195
This allows auth0_ex to be used with okta as well as auth0 🙂